Migrate x/auth cmd's to TxGenerator marshaling #6391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6391 +/- ##
==========================================
+ Coverage 56.13% 56.26% +0.12%
==========================================
Files 467 469 +2
Lines 28061 28091 +30
==========================================
+ Hits 15753 15806 +53
+ Misses 11201 11170 -31
- Partials 1107 1115 +8 |
aaronc
changed the title
aaronc
changed the title
8 tasks
* fixed lint issue of "txEncodeRespStr" * added tests for encode.go * WIP: added tests for decode.go * added txEncoder at bytes * updated decode test * updated txBytes to use TxEncoder in decoder test * added a require after TxEncoder * removed file save * debug decode command * fixed decode tests * added decode cli * updated encode and decode in a single file * separated decode test from encode test * review changes * removed register interface * review change
…ronc/6213-cli-encode
aaronc
requested review from
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
anilcse
reviewed
Jun 15, 2020
anilcse
reviewed
Jun 15, 2020
|
@fedekunze @anilcse can we please postpone tests for @fedekunze can you take another look and see if it's alright to move forward with this PR with the understanding that this is part of a larger migration of those other commands. |
|
Still fixing one test btw... |
fedekunze
approved these changes
Jun 18, 2020
|
@fedekunze fixed tests and added |
alessio
reviewed
Jun 18, 2020
aaronc
removed
the
A:automerge
|
@aaronc looks like a test is failing |
alessio
approved these changes
Jun 18, 2020
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* Migrate encode, decode, and broadcast cmd's to use TxGenerator marshal methods * Fix tests, add EncodingConfig * Add simapp/encoding.go and wire up with simcli * add godocs * fix tests * Debugging CLI Tests * Fix integration test * 6391 - lint issues and code coverage (cosmos#6414) * fixed lint issue of "txEncodeRespStr" * added tests for encode.go * WIP: added tests for decode.go * added txEncoder at bytes * updated decode test * updated txBytes to use TxEncoder in decoder test * added a require after TxEncoder * removed file save * debug decode command * fixed decode tests * added decode cli * updated encode and decode in a single file * separated decode test from encode test * review changes * removed register interface * review change * Fix tests * WIP add test for tx sign * removed commented code * Fix flags * WIP add test for sign * Address review suggestions * fixed command issue * Add tests for TxEncoder * Revert sign changes * Fix TxEncoder tests * Fix GetSign Cmd * Add tx test * Remove duplicate validation * Add tests for TxDecoder * Fix tests * Fix tests * Output to clientCtx.Output * Fix cli_tests Co-authored-by: atheeshp <[email protected]> Co-authored-by: atheesh <[email protected]> Co-authored-by: anilCSE <[email protected]> Co-authored-by: sahith-narahari <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of several bite-size PR's that are being pulled out of #6216 to implement #6213.
Summary
This PR makes incremental progress on migrating the remaining
x/authCLI commands to the new infrastructure for protobuf as well as setting the foundation for #6190.Details
TxEncoder|DecoderandTxJSONEncoder|Decodermethods toTxGeneratorand removeMarshalmethod.x/authencode,decode,broadcast,sign,multisign, andvalidate-signaturesCmd's to use theTxGeneratorEncoder/DecodermethodsEncodingConfigstruct andMakeEncodingConfigmethods tosimappandsimapp/paramsto incrementally move towards Full amino encoding support #6190.std.Codec(which is no longer needed because ofAny) and replace withcodec.MarshalerBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer